This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Error handler for Deposit autoSubmit funding proof error#118
Merged
Shadowfiend merged 2 commits intomasterfrom Mar 18, 2021
Merged
Error handler for Deposit autoSubmit funding proof error#118Shadowfiend merged 2 commits intomasterfrom
Shadowfiend merged 2 commits intomasterfrom
Conversation
The event emitter was renamed to a generic name, so it won't be dedicated to just one type of event but it will be used for different types of events.
Previously when an error was returned from `provideBTCFundingProof` transaction in the `autoSubmit` flow an UnhandledPromiseRejectionWarning was logged, user of the library had no chance to handle this error. As autoSubmit happens asynchronously we need a way to bubble up the error. In this proposed approach we catch the error an emit it as an event. User is required to define error callback with `onError` function.
Shadowfiend
reviewed
Feb 18, 2021
| } | ||
| ) | ||
| }) | ||
| .catch(this.notifyError) |
Contributor
There was a problem hiding this comment.
Why not take an onError or similar parameter to autoSubmit? It could be optional if someone wanted to handle errors directly on the promise, and we could also emit the event.
In general, a hybrid mechanism where we move to promise workflow + events depending on what the consumer wants to use might be a nice transition for a future direction.
Contributor
|
Merging this as-is, but flagging that I'm still interested in the parameter being passed in addition to the notification approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously when an error was returned from
provideBTCFundingProoftransaction in theautoSubmitflow anUnhandledPromiseRejectionWarningwas logged, a user of the library had no chance to handle this error.As auto submit happens asynchronously we need a way to bubble up the error.
In this proposed approach we catch the error and emit it as an event. User is required to define error callback with
onErrorfunction.